Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filters): Dec 19 #1038

Merged
merged 12 commits into from
Dec 30, 2024
Merged

fix(filters): Dec 19 #1038

merged 12 commits into from
Dec 30, 2024

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Dec 19, 2024 •
edited
Loading

fixes #1035
fixes #361
fixes #147
refs #288
refs #318
refs #151 (firefox specific fix required)
fixes #166
fixes #172
fixes #441

! https://github.com/ghostery/broken-page-reports/issues/1035
suburbanjunglegroup.com##body>div[consent-skip-blocker]
suburbanjunglegroup.com##html[style^="overflow"],body[style^="overflow"]:style(overflow: auto !important;)

! https://github.com/ghostery/broken-page-reports/issues/361
! desktop
plex.tv##.cookie-consent.container-standard
! mobile
plex.tv##html.remodal-is-locked:style(overflow: auto !important)
plex.tv##.remodal-wrapper.remodal-is-opened:has(.cookie-consent)
plex.tv##.remodal-overlay.remodal-is-opened:has(~.remodal-wrapper.remodal-is-opened>.cookie-consent)

! https://github.com/ghostery/broken-page-reports/issues/147
sat1.de##cmp-banner

! https://github.com/ghostery/broken-page-reports/issues/318
ohga.it##.gdpr-modal

! https://github.com/ghostery/broken-page-reports/issues/151
derstandard.at##body[data-pur]>[id^="sp_message_container_"]

! https://github.com/ghostery/broken-page-reports/issues/166
combi.de##.modal--cookie-notice.open

! https://github.com/ghostery/broken-page-reports/issues/288
routerdefaults.org#@#html:style(overflow: auto;)
routerdefaults.org##html[style*="overflow"]:style(overflow: auto;)

! https://github.com/ghostery/broken-page-reports/issues/172
lvz.de##[id^="sp_message_container_"]

! https://github.com/ghostery/broken-page-reports/issues/441
simply-connect.net#@#.cc-window[aria-label="cookieconsent"]

@seia-soto seia-soto self-assigned this Dec 19, 2024
@seia-soto seia-soto requested a review from Dimi-GE December 27, 2024 08:34
@seia-soto seia-soto marked this pull request as ready for review December 27, 2024 08:50
Dimi-GE
Dimi-GE reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@Dimi-GE Dimi-GE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! https://github.com/ghostery/broken-page-reports/issues/1035
With the custom filters applied, the web page becomes unresponsive for scrolling.

@Dimi-GE
Copy link
Contributor

Dimi-GE commented Dec 27, 2024

! https://github.com/ghostery/broken-page-reports/issues/361
The issue persists for:
iOS 18.2;
Safari 18.2;
GBE 10.4.19;

@Dimi-GE
Copy link
Contributor

Dimi-GE commented Dec 27, 2024

! https://github.com/ghostery/broken-page-reports/issues/147
Fixed.

@Dimi-GE
Copy link
Contributor

Dimi-GE commented Dec 27, 2024

! https://github.com/ghostery/broken-page-reports/issues/288

The issue randomly handled for the Firefox — I would assume it is a timing matter now as the new version of the extension is still on the AMO review.

However, Safari does not handle it at all:

image

@Dimi-GE
Copy link
Contributor

Dimi-GE commented Dec 27, 2024

! https://github.com/ghostery/broken-page-reports/issues/318
Problem remains for Firefox:

image

@Dimi-GE
Copy link
Contributor

Dimi-GE commented Dec 27, 2024

! https://github.com/ghostery/broken-page-reports/issues/151
Problem remains for Firefox:

image

@seia-soto seia-soto marked this pull request as draft December 27, 2024 10:58
@seia-soto
Copy link
Member Author

seia-soto commented Dec 27, 2024 •
edited
Loading

scheduling next iteration:

@seia-soto
Copy link
Member Author

@Dimi-GE please test new changes:

affected cases:

relevant custom filters:

! https://github.com/ghostery/broken-page-reports/issues/1035
suburbanjunglegroup.com##body>div[consent-skip-blocker]
suburbanjunglegroup.com##html[style^="overflow"],body[style^="overflow"]:style(overflow: auto !important;)

! https://github.com/ghostery/broken-page-reports/issues/361
! desktop
plex.tv##.cookie-consent.container-standard
! mobile
plex.tv##html.remodal-is-locked:style(overflow: auto !important)
plex.tv##.remodal-wrapper.remodal-is-opened:has(.cookie-consent)
plex.tv##.remodal-overlay.remodal-is-opened:has(~.remodal-wrapper.remodal-is-opened>.cookie-consent)

@seia-soto seia-soto marked this pull request as ready for review December 30, 2024 06:05
@seia-soto seia-soto merged commit a620858 into ghostery:main Dec 30, 2024
1 check passed
@seia-soto seia-soto deleted the filters/1219 branch December 31, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimi-GE Dimi-GE Dimi-GE approved these changes

Assignees

@seia-soto seia-soto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simply-connect.net plex.tv lvz.de combi.de sat1.de
suburbanjunglegroup.com
2 participants
@seia-soto @Dimi-GE